Skip to content

add tooltips to show who reacted to your post/comment on main feed#17

Open
hamnox wants to merge 2 commits intopfrazee:masterfrom
hamnox:reactions-tooltip
Open

add tooltips to show who reacted to your post/comment on main feed#17
hamnox wants to merge 2 commits intopfrazee:masterfrom
hamnox:reactions-tooltip

Conversation

@hamnox
Copy link
Copy Markdown
Contributor

@hamnox hamnox commented Apr 14, 2021

This needs someone's eyes, it's not optimized for styling.

notes

  • had to remove overflow:hidden style on parent div, it was causing the tooltip to not render on thread-view.
    • I tested a long sequence of reacts, it looks like they wrap onto more lines fine.
  • also shows tooltip on expanded view, as it's the same function that renders the reactions in both styles. it could in theory take an argument but that feels inconsistent with the coding style.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pfrazee/ctznry/8Y5acQKyhn76mmVRtisX6yype1FX
✅ Preview: https://ctznry-git-fork-hamnox-reactions-tooltip-pfrazee.vercel.app

@hamnox
Copy link
Copy Markdown
Contributor Author

hamnox commented Apr 14, 2021

Loom Video

Reactions with many clicks are clipping at the edge of posts-feed. Possible solution: make a tooltip that is flush with the start of the reactions instead, limit the number of characters it shows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant